Skip to content

Fix wildcards on ignore and includes #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2019
Merged

Fix wildcards on ignore and includes #36

merged 1 commit into from
Oct 25, 2019

Conversation

NelsonVides
Copy link
Contributor

Fix #35, I'm so sorry this was overlooked, thank you for reporting it!

If you're on the mood, try to break it, maybe some evil wildcard maybe 😄

@NelsonVides NelsonVides mentioned this pull request Oct 22, 2019
Closed
lukebakken
lukebakken approved these changes Oct 22, 2019
View reviewed changes
Copy link

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected 👍

works-on-my-machine-badge-small

@lukebakken
Copy link

@hcs42 could this be merged, please? I have confirmed that it fixes the issue.

@hcs42 hcs42 merged commit 4b332f4 into vim-erlang:master Oct 25, 2019
@NelsonVides NelsonVides deleted the fix_ignore_wildcards branch October 26, 2019 09:46
@lukebakken
Copy link

lukebakken commented Oct 26, 2019 •
edited
Loading

@hcs42 thank you! @NelsonVides thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--ignore not working with wildcards after recent refactor
3 participants
@NelsonVides @lukebakken @hcs42